Session Replay masking does not mask input placeholders

amplitude / Amplitude-TypeScript

TypeScript Amplitude Analytics SDK

https://amplitude.github.io/Amplitude-TypeScript/

MIT License

132 stars 38 forks source link

Session Replay masking does not mask input placeholders #887

Open GxDesign opened 1 month ago

GxDesign commented 1 month ago

Expected Behavior

All text displayed in an input should be masked if using conservative or amp-mask class

Current Behavior

Placeholder text is not masked. This is an issue for searchable dropdown components which may update the placeholder value to the selected option.

Steps to Reproduce

create an input with placeholder text and apply amp-mask

Environment

"@amplitude/session-replay-browser": "1.13.9"
"react": "17.0.2",

lewgordon-amplitude commented 3 weeks ago

Seems reasonable. We have an internal ticket to track this. We'll update this Github ticket accordingly. Thanks for the feedback!

lewgordon-amplitude commented 2 weeks ago

Hey @GxDesign as I was going through the implementation, which I'd like to get merged upstream I saw this issue being raised for rrweb. If it gets accepted we'll pick up the upstream change. If it gets rejected I may go ahead with my implementation. Hope that helps!