amplitude / Amplitude-iOS

Native iOS/tvOS/macOS SDK
MIT License
303 stars 192 forks source link

Add nullability marks for better Swift compatibility #196

Open abekert opened 5 years ago

abekert commented 5 years ago

It's better to mark properties and parameters nullability in your Objective-C SDK. Please, look at the article, or at the other one where it's explained.

A quick example — I don't know am I allowed to pass nil as value of AMPIdentify().set("key", value: isNilValueAllowedHere)

haoliu-amp commented 4 years ago

Agree on this. Thanks.