amplitude / analytics-go

Go Amplitude Analytics SDK
MIT License
12 stars 7 forks source link

fix: AMP-57521-EventOptions #10

Closed Mercy811 closed 2 years ago

Mercy811 commented 2 years ago

Summary

Checklist

kevinpagtakhan commented 2 years ago

Question: In typescript, the BaseEvent class extends the EventOptions class. So the keys in EventOptions are at the same level as event_type / event_properties and etc. https://github.com/amplitude/Amplitude-TypeScript/blob/main/packages/analytics-types/src/base-event.ts#L11

In go here, we have another key for EventOptions in the Event struct. Are those two align?

https://github.com/amplitude/Amplitude-Go/pull/10/files#diff-6caf76ab3481a2e4beb6ba9a3c720ba47735829fbe9e6dab9279edae8249de48L23

I think Go does not have inheritance like other languages do; and this is the closest thing in Go.