amplitude / analytics-go

Go Amplitude Analytics SDK
MIT License
12 stars 7 forks source link

feat: Client #5

Closed Mercy811 closed 2 years ago

Mercy811 commented 2 years ago

Summary

Checklist

Questions & Request for review

  1. Since APIs of Client are exposed to users, I use value receiver at the most of the time. But for Add, Remove, and Shutdown which updates plugins and changes the client instance itself, I use pointer receiver there. I am wondering if that is right.
  2. When initialize a new BaseEvent, linter says some fields are missing. As for Go standard, do I need to explicitly assign empty value to the fields of BaseEvent when I init it?