feat: AMP-56378-timeline - Githubissues

amplitude / analytics-go

Go Amplitude Analytics SDK

MIT License

12 stars 7 forks source link

feat: AMP-56378-timeline #6

Closed Mercy811 closed 2 years ago

Mercy811 commented 2 years ago

Summary

timeline
- timeline implemented without multi threads
- add() and remove() to add and remove plugins
- process() to process/enrich events
- flush() and shutdown() sends events to assigned destinations
- made all methods of timeline private, since they should not be exposed to users
plugins
- refactor plugins in more go style
- two types (interfaces) plugins:
- EnrichmentPlugin for BEFORE and ENRICHMENT type
- DestinationPlugin for DESTINATION type

Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:

Mercy811 commented 2 years ago

Applied https://github.com/amplitude/Amplitude-Go/commit/1ef72e780994144384aa3434f26cbaf681b81927. And for my understanding what it does:

Created EnrichmentPlugin and DestinationPlugin interfaces instead of struct
EnrichmentPlugin inlcudes BEFORE and ENRICHMENT plugins, and use MiddlewarePriority to distinguish them
In timeline, separate Plugins into middlewarePlugins and destinationPlugins

Changes in https://github.com/amplitude/Amplitude-Go/pull/6/commits/28364c5b50e1c6c74b9fbec6dad93ae5a22a02d8 for API consistency:

Client add and remove plugins methods

client.add(plugin)
client.remove(plugin)

Changed the name of MiddlewarePlugin to EnrichmentPlugin