search

amplitude / unity-plugin

Official Amplitude Unity Plugin
https://developers.amplitude.com/docs/unity
MIT License
44 stars 34 forks source link

Android jar files being placed in package manager plugins folder when resolved #112

Closed JonLandmark closed 1 year ago

JonLandmark commented 1 year ago

I have the Amplitude SDK added to the project using the UPM. The External Dependency Manager is resolving successfully for android but it is placing the jar files under two locations...

Assets/Plugins/Android Packages/Amplitude Unity SDK/Plugins/Android

Any idea how I can stop it from adding the jar files into the plugins folder inside the amplitude folder? At the moment it fails to build due to the same files being in both locations.

qingzhuozhen commented 1 year ago

@JonLandmark Thanks for reporting this. I wonder if this is related for we include the ExternalDependencyManager as reported in https://github.com/amplitude/unity-plugin/issues/111. Will dive more into this.

snorrsi commented 1 year ago

@JonLandmark good that you noticed my edm4u issue but I don’t think that’s the case as I am using a version with the edm4u removed and it seems that added the file in two places as mentioned

snorrsi commented 1 year ago

@JonLandmark I took a look at my old Amplitude UPM 2.4.0 package and noticed I have previously fully removed the Plugins/Android folder as it’s not needed since everything is resolved with edm4u. If you remove the folder then you should get rid of this duplication error

JonLandmark commented 1 year ago

@snorrsi If I delete the Plugins/Android folder inside the amplitude package, it just recreates the whole folder when unity recompiles (I'm guessing because that plugins folder is actually committed in with some content). Have you created your own fork to manually remove them?

@qingzhuozhen For some reason the resolved files are different in each location. Here are the files inside each folder for my project in case it's any help in diagnosing.

Assets/Plugins/Android...

com.amplitude.android-sdk-2.34.1.aar com.android.installreferrer.installreferrer-2.1.aar com.appsflyer.af-android-sdk-6.8.0.aar com.appsflyer.oaid-6.2.4.aar com.appsflyer.unity-wrapper-6.8.1.aar com.squareup.okhttp3.okhttp-4.2.2.jar com.squareup.okio.okio-2.2.2.jar org.jetbrains.annotations-13.0.jar org.jetbrains.kotlin.kotlin-stdlib-1.6.10.jar org.jetbrains.kotlin.kotlin-stdlib-common-1.6.10.jar org.jetbrains.kotlin.kotlin-stdlib-jdk7-1.6.10.jar org.jetbrains.kotlin.kotlin-stdlib-jdk8-1.6.10.jar

Packages/Amplitude Unity SDK/Plugins/Android...

com.amplitude.android-sdk-2.34.1.aar com.squareup.okhttp3.okhttp-4.2.2.jar com.squareup.okio.okio-2.2.2.jar org.jetbrains.annotations-13.0.jar org.jetbrains.kotlin.kotlin-stdlib-1.3.50.jar org.jetbrains.kotlin.kotlin-stdlib-common-1.3.50.jar

snorrsi commented 1 year ago

@JonLandmark yes I created branch at https://github.com/snorrsi/amplitude-unity-plugin/tree/v2.5.1-noedm4u

@qingzhuozhen the previous messages were meant to you

qingzhuozhen commented 1 year ago

Thanks for the info. Created a tag v2.6.0-no-edm-and-dep without ExternalDependencyManager and Android files, hope that could help.

justin-fiedler commented 1 year ago

Hi @JonLandmark were you able to try the fix provided above? Thank you

justin-fiedler commented 1 year ago

Closing due to lack of activity.