amplitude / unity-plugin

Official Amplitude Unity Plugin
https://developers.amplitude.com/docs/unity
MIT License
44 stars 34 forks source link

Enabling tvOS compile on .h/.m files, updating AmplitudePostProcessor.cs #81

Closed keerthik closed 2 years ago

keerthik commented 3 years ago

This commit trivially enables Amplitude to work on tvOS builds in addition to existing targets, and has been tested with our sample application and production application in beta.

keerthik commented 3 years ago

These changes can be reproduced by following these steps:

Amplitude's Unity plugin will work on tvOS with modifications:

dantetam commented 3 years ago

Hello @keerthik ,

Thank you for providing this PR. There may be some changes on our end we will have to complete. We plan to integrate and do our own testing and bug fixes within 2-3 weeks. We may or may not keep EventExplorer, depends on our product need.

I'll definitely start by testing out this branch.

Dante

keerthik commented 3 years ago

Thank you, we are targeting release of our Unity project using Amplitude to tvOS next month, happy to assist with the merge or field testing. In the meantime we plan to proceed using my fork of this repo.

keerthik commented 2 years ago

Just wanted to bump this pull request with an update that we have been able to receive analytics from tvOS devices without issue, reporting OS version, creating a unique device id, and recording user events without a problem.

keerthik commented 2 years ago

I see this issue was closed along with rejection — does the new release from the original library compile work on tvOS with the above tasks (record device id, map to OS version, track user events sent from Unity)? Or should I continue using my fork for tvOS Unity builds?

dnshi commented 2 years ago

Thanks for the PR. I will create a separate PR for the change.