search

ampproject / amp-by-example

DEPRECATED: AMP by Example has been merged into amp.dev
http://amp.dev
Apache License 2.0
753 stars 505 forks source link

Docking Sample: sidebar too narrow on mobile #1578

Open sebastianbenz opened 5 years ago

sebastianbenz commented 5 years ago
screen shot 2018-10-23 at 09 24 31

@alanorozco can you take a look?

alanorozco commented 5 years ago

This can be partially fixed (#1581) but I realized that the sliding animation would run, covering some of the space.

This should be fixed at the AMP level to provide separate dockedOnSlot and undockedFromSlot events.

@aghassemi WDYT?

aghassemi commented 5 years ago

mmm this sounds like a mis-configured media query to me. I don't expect the sidebar or slot-docking on mobile sizes.

alanorozco commented 5 years ago

Sure, but the layout is different on responsive. The aside should not slide if there's no docking slot available.

We can either:

  1. Fix the example to hide the aside, but expectations might be different (?).
  2. Add docking actions that are specific to docking on slot and trigger the example animation only on those actions.
aghassemi commented 5 years ago

as discussed offline: dockedOnSlot and undockedFromSlot events seem reasonable.

alanorozco commented 5 years ago

This will be addressed as triggering dock from two different elements (the dock or the video itself). (as discussed later :)