Closed tharders closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
ℹ️ Googlers: Go here for more info.
I signed it
I signed it
@tharders you need to change the commit email address to match the one you've used to sign the CLA. The current email address is thorsten.harders@tho...
.
For the amp docs project the header id generation should match the grow logic: All characters but whitespace are allowed See https://github.com/ampproject/docs/issues/1892 And https://github.com/grow/grow/commit/62d0a6aeff8187e6bace24a89b9f74ec8f17e509#diff-506b8f06fee5ce1722a3c180ab3919b7
If there are no side effects to be expected with oder use of the amp-by-example project, please consider accepting this pull request.