search

ampproject / amp-toolbox-php

AMP Optimizer PHP library
Apache License 2.0
73 stars 25 forks source link

Fix SSR sizer responsiveness issue #521

Closed ediamin closed 2 years ago

ediamin commented 2 years ago

Fixes #511

This PR fixes the responsiveness issue of the i-amphtml-sizer generated by the SSR when we have a heights attribute.

westonruter commented 2 years ago

This is a port of https://github.com/ampproject/amp-toolbox/pull/1319, correct?

westonruter commented 2 years ago

Should the test suite from amp-toolbox be synced as part of this PR to ensure everything passes?

ediamin commented 2 years ago

Yes, it was sync and merged in this PR https://github.com/ampproject/amp-toolbox-php/pull/520