search

ampproject / amp-toolbox

A collection of AMP tools making it easier to publish and host AMP pages.
Apache License 2.0
449 stars 243 forks source link

Show blurredPlaceholders warning only when enabled #1151

Closed att55 closed 3 years ago

att55 commented 3 years ago

Overview

Hi there!

I found that the warning of blurredPlaceholders was shown even if blurredPlaceholders option was disabled. https://github.com/ampproject/amp-toolbox/tree/main/packages/optimizer#blurry-image-placeholders

AMP Optimizer AddBlurryImagePlaceholders WARNING jimp and lru-cache need to be installed via `npm install jimp lru-cache` for this transformer to work

I don't think there is a need to show the waring when the option is disabled. So, I change that the waring is shown only when the option is enabled.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.