search

ampproject / amp-toolbox

A collection of AMP tools making it easier to publish and host AMP pages.
Apache License 2.0
449 stars 243 forks source link

Handle removal of "latestVersion" from extensions bundle configuration #1272

Closed erwinmombay closed 2 years ago

erwinmombay commented 2 years ago

latestVersion was recently removed in https://github.com/ampproject/amphtml/commit/4df29d5cb8c054a42fafc8cfe0e07259c678754d#diff-e1e01796130015ee103b63a398890524b618b40f0dd857a788d1c14003ee490b so tests started to fail. Need to handle its removal on the auto importer.

also the previous configuration seemed inaccurate such as "latestVersion" was left at 0.1 for example even though there was already a 1.0 newer version entry in the config. (see amp-timeago, amp-accordion)

erwinmombay commented 2 years ago

@sebastianbenz PTAL

erwinmombay commented 2 years ago

cc @samouri

samouri commented 2 years ago

I'm a bit confused by the AutoImport plugin. How is it used in the wild? It makes sense to me in the context of someone first writing an AMP Page and wanting a good DevEx as they do it (sort of like an external build_cleaner).

But its clear to me that folks shouldn't keep an empty <head> and rely on AutoImporter to guess the right version for them, because that would mean we can never change the version AutoImporter adds as we update to new versions (Bento)

schlessera commented 2 years ago

@sebastianbenz, @erwinmombay, This change now pulls in experimental versions by default, instead of only stable versions. As an example, it now uses version 1.0 of amp-timeago instead of version 0.1. Version 1.0 is still marked as experimental: https://amp.dev/documentation/components/amp-timeago-v1.0/?format=websites

sebastianbenz commented 2 years ago

@schlessera good catch! We need to fix this!

westonruter commented 2 years ago

I've asked for there to be a new reference to easily read which component versions are still experimental: https://github.com/ampproject/amphtml/issues/36749#issuecomment-996160595.