search

ampproject / amp-viewer

Apache License 2.0
38 stars 34 forks source link

Fix a few lint warnings #60

Closed zhangsu closed 7 years ago

zhangsu commented 7 years ago 
  1. Function must have JSDoc.
export function log() {
     ^^^^^^^^^^^^^^^^

  2. import statements are not sorted.

  3.   channel.port1.onmessage = e => {
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  4. Bad type annotation. expected closing } See https://github.com/google/closure-compiler/wiki/Bad-Type-Annotation for more information.
* @param {!Function():boolean} isViewerHidden method that determines if viewer is hidden.

  5. Extra @return clauses in the JsDoc