ampproject / amp-viewer

Apache License 2.0
38 stars 34 forks source link

Fix crashes and hangs on build #69

Open gravityrail opened 6 years ago

gravityrail commented 6 years ago

I got an error with the require() path needing to reference a sibling directory. Also the watch flag was not being respected properly for gulp build and was watching every time.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
gravityrail commented 6 years ago

I signed it!

gravityrail commented 6 years ago

More to the point, I tried to sign it a hundred different ways and it failed for different reasons each time. That form is... pretty bad.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.