search

ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.
https://wordpress.org/plugins/amp/
GNU General Public License v2.0
1.79k stars 382 forks source link

Validation error for hoverintent-js appearing in WP 5.3.1 #3927

Closed Lofesa closed 4 years ago

Lofesa commented 4 years ago

Hi I have upgraded WP to version 5.3.1 and now in validation have a new issue with a js file loaded in the admin side, wp-includes/js/hoverintent-js.min.js Is loaded by the WP core file script-loader.php:2647 cript-loader.php:2637

westonruter commented 4 years ago

Thanks for reporting this. I can see the same. We'll fix in 1.4.2. In the meantime, you can just leave the invalid markup as “Removed”.

westonruter commented 4 years ago

Another problem with WordPress 5.3.1 with hoverintent being removed is the admin bar dropdowns don't appear. This is also fixed in #3928 by including hoverintent in dev mode.

Lofesa commented 4 years ago

Hi If I put these changed file to the 1.5.0-alpha-20191207T181223Z-c3e9208b version I have it must work?

EDIT: No, cause the 1.5.0-alpha-20191207T181223Z-c3e9208b version addresses the JSON issue and the changes are not in this file.

westonruter commented 4 years ago

@Lofesa I've made a build with the PR applied to the 1.4 branch. Please test v1.4.2-alpha-20191215T003107Z-8e22e4f0: amp.zip

Lofesa commented 4 years ago

But this build contain the changes made in PR #3898 ? If not then I will make some trick to get back the JSON

westonruter commented 4 years ago

@Lofesa Here's a build which includes the changes from both PRs #3898 and #3928: https://github.com/ampproject/amp-wp/pull/3928#issuecomment-565861292

Build for testing: amp.zip (1.5.0-alpha-20191216T000003Z-64a80518)

Lofesa commented 4 years ago

@westonruter It work.

rsmith4321 commented 4 years ago

Great I was having the same issue, thanks.