ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.
https://wordpress.org/plugins/amp/
GNU General Public License v2.0
1.78k stars 381 forks source link

amp-iframe, amp-instagram, amp-youtube, amp-soundcloud wrapped in unnecessary p tags #4450

Open jerclarke opened 4 years ago

jerclarke commented 4 years ago

Bug Description

This is a continuation of #4358 where the same problem applied to amp-facebook and was fixed.

The premise is that these amp-* objects should be in the root of the document, and not be wrapped in <p> tags. Twitter already worked this way, and in #4358 amp-facebook was fixed to match.

I've now noticed that amp-iframe, amp-instagram, amp-youtube, amp-soundcloud face the same problem:

Screen Shot 2020-03-25 at 7 19 09 PM Screen Shot 2020-03-25 at 7 21 08 PM Screen Shot 2020-03-26 at 3 50 05 PM

As with the previous ticket, it's important to me because I need to style something that immediately follows the object (amp-instagram+.translation), but also generally it just seems like good practice all around.

Instagram embed code:

[embed]https://www.instagram.com/p/Buq8vU6Hcxn/[/embed]
<blockquote class="translation">This is a translation of the Instagram post above.</blockquote>

YouTube embed code

[embed]https://www.youtube.com/watch?v=vXPJVwwEmiM[/embed]
<blockquote class="translation">This is a translation of the YouTube video above.</blockquote>

Soundcloud embed code

[embed]https://soundcloud.com/globalvoices/summitpodcast[/embed]

Mostly likely this applies to other embeds as well. A general review would be greatly appreciated.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

jerclarke commented 1 year ago

Just here to say, would still be great to get this consistent!

Also noticed that this also applies to amp-iframe, which affects Tumblr and Mastodon 😅