When a Reader theme has been selected for Reader mode, the Customizer opened from an AMP page will be distinctly for the theme that was chosen for Reader mode. It will have the theme-specific settings for the Reader theme instead of the settings for the active theme. Additionally, the Themes panel and Widgets panels are removed from the AMP Customizer:
Non-AMP Customizer
AMP Customizer
Nevertheless, there are settings which are common to both versions of the Customizer: any which are not tied to theme_mod settings.
Section/Panel
Shared
Not Shared
Site Identity
Site Title, Tagline, Site Icon
Logo, Retina Logo (in Twenty Twenty), Display Site Title and Tagline (in Twenty Fifteen, etc)
Themes may add/remove controls to each of these sections or even add new sections. Plugins may also add/remove controls to any of these sections.
When in the AMP Customizer, there should be some indication for the controls that will impact the non-AMP version of the site.
Menus: A general notice may make sense in the Menus panel to explain that the menus and menu items are shared, and that if they want to have an AMP-specific menu they should create a new menu and assign it to the desired location in the Reader theme.
Homepage Settings: Since this is entirely shared between AMP and non-AMP, perhaps this should just be removed entirely from the AMP Customizer. Otherwise, it should get a notice in the panel (if any of the controls have non-option settings).
Site Identity: Since the site title, tagline, and site icon are all shared, but the other settings are not, the shared controls should probably get individual notifications to say they are shared. This should probably go for every such control in sections other than Menus and Homepage Settings.
Feature description
When a Reader theme has been selected for Reader mode, the Customizer opened from an AMP page will be distinctly for the theme that was chosen for Reader mode. It will have the theme-specific settings for the Reader theme instead of the settings for the active theme. Additionally, the Themes panel and Widgets panels are removed from the AMP Customizer:
Nevertheless, there are settings which are common to both versions of the Customizer: any which are not tied to
theme_mod
settings.Themes may add/remove controls to each of these sections or even add new sections. Plugins may also add/remove controls to any of these sections.
When in the AMP Customizer, there should be some indication for the controls that will impact the non-AMP version of the site.
The Customizer API for adding notifications to controls can be seen here: https://make.wordpress.org/core/2016/07/05/customizer-apis-in-4-6-for-setting-validation-and-notifications/
The Customizer API for adding notifications to sections and panels can be found here: https://make.wordpress.org/core/2017/11/01/improvements-to-the-customize-js-api-in-4-9/#notification-improvements
The notifications should be added with JS as opposed to PHP to account for dynamically-created controls.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry