search

ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.
https://wordpress.org/plugins/amp/
GNU General Public License v2.0
1.79k stars 383 forks source link

AMP preview button seems to show duplicate logo when AMP sidebar is pinned #5943

Closed westonruter closed 11 months ago

westonruter commented 3 years ago

Bug Description

In Transitional/Reader modes, there is an AMP preview button that is separate from the regular Preview button. Additionally, as of #5589 there is a new plugin sidebar for displaying validation errors. When that sidebar is pinned, the result is an apparent duplication of the AMP buttons in the toolbar:

image

Granted we want to eliminate the separate AMP preview button in favor of adding an AMP item to the Preview dropdown, but this is blocked by https://github.com/WordPress/gutenberg/issues/25309. Nevertheless, I wanted to point it out as a potential source of user confusion in the meantime.

The resolution for this issue may be wontfix.

Expected Behaviour

The AMP logo should not appear multiple times in the toolbar.

Steps to reproduce

  1. Activate Reader or Transitional mode.
  2. Edit a post.
  3. Pin the AMP plugin sidebar
  4. See two logos in the toolbar

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

simison commented 3 years ago

There's a draft PR to add the capability in Gutenberg https://github.com/WordPress/gutenberg/pull/25430

@westonruter Would anyone from the AMP team be up for helping to wrap that PR up? It seems so close! 😅

westonruter commented 3 years ago

@delawski Is https://github.com/WordPress/gutenberg/pull/25430 something you can take up?

delawski commented 3 years ago

@westonruter @simison I'll have a look and see what I can do about it.