Bump minimum required WP to 6.3

thelovekesh commented 3 months ago

Summary

Bump minimum required WordPress version to 6.3.
Update all NPM packages to the latest versions.
Remove legacy code used to maintain compatibility with WP < 6.3.
Add polyfill for new React JSX runtime. See https://make.wordpress.org/core/2024/06/06/jsx-in-wordpress-6-6/ and https://make.wordpress.org/core/2024/06/06/jsx-in-wordpress-6-6/#comment-46779.
Remove legacy classes like AMP_Block_Uniqid_Sanitizer, and BlockUniqidTransformer and their test case files.
Remove object and page caching site health tests. Also removed notice to purge page cache from assets/src/settings-page/settings-footer.js.
Remove the amp_page_cache_good_response_time_threshold filter which was deprecated in AMP 2.5.0 in favor of WP's site_status_good_response_time_threshold.
Convert SVG icons to React components using @wordpress/primitives.

Checklist

[x] My code is tested and passes existing tests.
[x] My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (22012c5) to head (a16b1dc).

:exclamation: Current head a16b1dc differs from pull request most recent head ac43705

Please upload reports for the commit ac43705 to get more accurate results.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816/graphs/tree.svg?width=650&height=150&src=pr&token=WRQUQXXDzS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject)](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) ```diff @@ Coverage Diff @@ ## develop #7816 +/- ## ============================================= - Coverage 77.21% 77.08% -0.14% + Complexity 6910 6777 -133 ============================================= Files 210 276 +66 Lines 21518 22303 +785 ============================================= + Hits 16616 17193 +577 - Misses 4902 5110 +208 ``` | [Flag](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) | `65.29% <89.28%> (?)` | | | [php](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) | `77.76% <75.00%> (+0.55%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) | `77.76% <75.00%> (+0.55%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) | Coverage Δ | | |---|---|---| | [amp.php](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=amp.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YW1wLnBocA==) | `0.00% <ø> (ø)` | | | [...validation/components/amp-document-status/index.js](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=assets%2Fsrc%2Fblock-validation%2Fcomponents%2Famp-document-status%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YXNzZXRzL3NyYy9ibG9jay12YWxpZGF0aW9uL2NvbXBvbmVudHMvYW1wLWRvY3VtZW50LXN0YXR1cy9pbmRleC5qcw==) | `94.73% <ø> (ø)` | | | [...s/amp-validation-status/revalidate-notification.js](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=assets%2Fsrc%2Fblock-validation%2Fcomponents%2Famp-validation-status%2Frevalidate-notification.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YXNzZXRzL3NyYy9ibG9jay12YWxpZGF0aW9uL2NvbXBvbmVudHMvYW1wLXZhbGlkYXRpb24tc3RhdHVzL3JldmFsaWRhdGUtbm90aWZpY2F0aW9uLmpz) | `90.90% <ø> (ø)` | | | [...nents/amp-validation-status/status-notification.js](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=assets%2Fsrc%2Fblock-validation%2Fcomponents%2Famp-validation-status%2Fstatus-notification.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YXNzZXRzL3NyYy9ibG9jay12YWxpZGF0aW9uL2NvbXBvbmVudHMvYW1wLXZhbGlkYXRpb24tc3RhdHVzL3N0YXR1cy1ub3RpZmljYXRpb24uanM=) | `95.00% <ø> (ø)` | | | [...block-validation/components/error/error-content.js](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=assets%2Fsrc%2Fblock-validation%2Fcomponents%2Ferror%2Ferror-content.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YXNzZXRzL3NyYy9ibG9jay12YWxpZGF0aW9uL2NvbXBvbmVudHMvZXJyb3IvZXJyb3ItY29udGVudC5qcw==) | `100.00% <ø> (ø)` | | | [...ock-validation/components/error/error-type-icon.js](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=assets%2Fsrc%2Fblock-validation%2Fcomponents%2Ferror%2Ferror-type-icon.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YXNzZXRzL3NyYy9ibG9jay12YWxpZGF0aW9uL2NvbXBvbmVudHMvZXJyb3IvZXJyb3ItdHlwZS1pY29uLmpz) | `100.00% <ø> (ø)` | | | [...sets/src/block-validation/components/icon/index.js](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=assets%2Fsrc%2Fblock-validation%2Fcomponents%2Ficon%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-YXNzZXRzL3NyYy9ibG9jay12YWxpZGF0aW9uL2NvbXBvbmVudHMvaWNvbi9pbmRleC5qcw==) | `100.00% <ø> (ø)` | | | [includes/admin/class-amp-post-meta-box.php](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=includes%2Fadmin%2Fclass-amp-post-meta-box.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-aW5jbHVkZXMvYWRtaW4vY2xhc3MtYW1wLXBvc3QtbWV0YS1ib3gucGhw) | `90.17% <ø> (-0.09%)` | :arrow_down: | | [includes/admin/class-amp-template-customizer.php](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=includes%2Fadmin%2Fclass-amp-template-customizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-aW5jbHVkZXMvYWRtaW4vY2xhc3MtYW1wLXRlbXBsYXRlLWN1c3RvbWl6ZXIucGhw) | `95.50% <ø> (-0.02%)` | :arrow_down: | | [includes/amp-post-template-functions.php](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree&filepath=includes%2Famp-post-template-functions.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject#diff-aW5jbHVkZXMvYW1wLXBvc3QtdGVtcGxhdGUtZnVuY3Rpb25zLnBocA==) | `100.00% <100.00%> (+2.43%)` | :arrow_up: | | ... and [18 more](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject) | | ... and [61 files with indirect coverage changes](https://app.codecov.io/gh/ampproject/amp-wp/pull/7816/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ampproject)

github-actions[bot] commented 2 months ago

Plugin builds for f508f8300c1478d6154fdc5ab531adc4349ca31b are ready :bellhop_bell:!

Download development build
Download production build

Checksums

# Development build checksums
a9632cbfb85a7d813e0c783ba2af02586d7eb8937955a4604b71954bb3e91965 *amp.zip

# Production build checksums
fad6c24abb0990b4edd3b3b00655420501d35574b3ed1a4c26beb89f1936e9ab *amp.zip

[!WARNING] These builds are for testing purposes only and should not be used in production.

thelovekesh commented 2 months ago

@westonruter There is a flaky end-to-end test that we can ignore for now; I'll address it separately. Currently, there's an issue where the AMP preview button in the post editor is sometimes not visible when the editor is first opened. It becomes visible only when the editor is in an editable state, such as when someone clicks on it. I can replicate this on WordPress 6.5, but not on the trunk version.

https://github.com/ampproject/amp-wp/blob/4b94713b43933008b5198f19a907f12a0b12c421/assets/src/block-editor/plugins/wrapped-amp-preview-button.js#L59-L61

pavanpatil1 commented 2 months ago

Verified it with WordPress v6.3,v6.5,v6.6RC2 and it is working fine. Checked the settings and related options those are working fine ✅

ampproject / amp-wp