ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.
https://wordpress.org/plugins/amp/
GNU General Public License v2.0
1.79k stars 382 forks source link

Fix form-label lint errors #7823

Closed thelovekesh closed 2 months ago

thelovekesh commented 2 months ago

Summary

Fix the following ESLint errors:

➜  amp git:(fix/eslint-errors) npm run lint:js

> lint:js
> wp-scripts lint-js

/home/thelovekesh/Desktop/work/google/wpdev/public/content/plugins/amp/assets/src/onboarding-wizard/pages/technical-background/index.js
  64:6  error  A form label must be associated with a control  jsx-a11y/label-has-associated-control
  97:6  error  A form label must be associated with a control  jsx-a11y/label-has-associated-control

✖ 2 problems (2 errors, 0 warnings)

Checklist

github-actions[bot] commented 2 months ago

Plugin builds for 479db32e112fbb5782025a72cd1d3866d4bcaabe are ready :bellhop_bell:!

Checksums
# Development build checksums
a63ad70debb226514d34f5d83d99ec6714536a3527574443d3983526e7197b14 *amp.zip

# Production build checksums
397397614101719da33610248747d9f7abeeb1924e57beabe524d617a636cd61 *amp.zip

[!WARNING] These builds are for testing purposes only and should not be used in production.

thelovekesh commented 1 month ago

There are no ESLint errors on the develop branch. QA Passed ✅ .