Update checkbox CSS - Githubissues

ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.

https://wordpress.org/plugins/amp/

GNU General Public License v2.0

1.79k stars 383 forks source link

Update checkbox CSS #7844

Closed thelovekesh closed 3 months ago

thelovekesh commented 3 months ago

Summary

Fixes #7843

Checklist

[x] My code is tested and passes existing tests.
[x] My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

github-actions[bot] commented 3 months ago

Plugin builds for 7ff821d6003d813647c77d8d27145a8473832fb5 are ready :bellhop_bell:!

Download development build
Download production build

Checksums

# Development build checksums
eb1a31afae0230ce557176cfeb36cff0b4cfc5a968c3ad9fcb0a8640a83f55f8 *amp.zip

# Production build checksums
1739887542ea99a0ca028eecdb48829be8d1731778d4c41931c9649f91525b9a *amp.zip

[!WARNING] These builds are for testing purposes only and should not be used in production.

westonruter commented 3 months ago

How did you figure out that this was the required CSS to fix the issue?

Otherwise, LGTM so I'm approving, but noting that @pavanpatil1 will be testing as well.

thelovekesh commented 3 months ago

How did you figure out that this was the required CSS to fix the issue?

We are updating the checkbox component appearance using our own CSS. I just inspected the styles and found the culprit.