search

ampproject / amp-wp

Enable AMP on your WordPress site, the WordPress way.
https://wordpress.org/plugins/amp/
GNU General Public License v2.0
1.79k stars 383 forks source link

Add AMP under "Preview" dropdown in WordPress #7896

Open simison opened 1 week ago

simison commented 1 week ago

Hi! I wanted to let you know that it's now possible to add items under "Preview" menu in Gutenberg since:

More here: https://make.wordpress.org/core/2024/10/18/extending-the-preview-dropdown-menu-in-wordpress-6-7/

I recommend moving the AMP preview there from the plugin toolbar conditionally when PreviewDropdownMenuItem is available:

Screenshot 2024-10-17 at 20 22 59

The original issue at Gutenberg repo used AMP as an example of why the Preview dropdown had to be extendable:

I wrote more ideas here on how to improve preview extensibility. Feel free to share AMP perspective!

kellychoffman commented 1 week ago

Perhaps for another issue, but I noticed the 'Preview in new tab' line has more left/right padding than the rest of the items.

westonruter commented 1 week ago

This is great as I understand it will eliminate some brittle code we've had to implement to work around this limitation:

https://github.com/ampproject/amp-wp/blob/60a655cdad9e3431b47b2dcc3b2e5ddb86ac5c5e/assets/src/block-editor/plugins/wrapped-amp-preview-button.js