search

ampproject / amp.dev

The AMP Project Website.
https://amp.dev
Other
583 stars 694 forks source link

Migrate to ESM #5651

Open matthiasrohmer opened 3 years ago

matthiasrohmer commented 3 years ago

Follow-up to https://github.com/ampproject/amp.dev/pull/5650.

p-queue is one of the first packages to deprecate usage via require but enforces using packages to migrate to Node.js-native module syntax as per https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c.

At a glance this seems like a daunting task for amp.dev but I fear there will soon be more packages to follow this decision. The question is how do we want to approach this?

/cc @sebastianbenz @patrickkettner @lluerich

sebastianbenz commented 3 years ago

Hm. Let's wait a bit and see what happens. Once critical dependencies make this step we should migrate as well. Otherwise, I'd prefer to not do this...

patrickkettner commented 3 years ago

A package like esm would make the transition much easier, if we choose that route