search

ampproject / amp.dev

The AMP Project Website.
https://amp.dev
Other
582 stars 694 forks source link

Redirect status.ampproject.org to status.amp.dev #5730

Closed estherkim closed 3 years ago

estherkim commented 3 years ago

Hello, can status.ampproject.org be redirected to status.amp.dev? The plan is to archive https://github.com/ampproject/amp-status . Thanks!

patrickkettner commented 3 years ago

blocked on #5732

patrickkettner commented 3 years ago

@estherkim that is sorted, so proceeding...

status.ampproject.org is setup to point to status.ampproject.org.cdn.cloudflare.net via CNAME inside of g3. This is working, in the sense that it is pointing to the github page that the cloudflare instance is pointing to, but as im sure you know, it has to be hosted on the same domain. Since cloudflare is already being used, the redirect makes sense to be controlled via page rules. Do you have control of the cloudflare instance? Or know who does?

estherkim commented 3 years ago

This is working, in the sense that it is pointing to the github page that the cloudflare instance is pointing to

@danielrozenberg do you know how to turn down the GitHub Page?

danielrozenberg commented 3 years ago

I removed the CNAME record on CloudFlare, however the root cause is that we are still handing off status.ampproject.org to CloudFlare's DNS server - I believe I know how to fix that, this is a Google-internal change as the domain is managed there

patrickkettner commented 3 years ago

@danielrozenberg If youve turned off the cloudflare hosting of those domains, where is the logic for the redirects going to live?

danielrozenberg commented 3 years ago

@danielrozenberg If youve turned off the cloudflare hosting of those domains, where is the logic for the redirects going to live?

In the DNS zone file, managed internally at Google. I made the change earlier today, but since it's non-urgent it would take a day or two to take effect

patrickkettner commented 3 years ago

how are you doing a redirect via DNS? A CNAME wouldn't work, since the hosting provider is doing domain validation, no?

On Wed, May 5, 2021 at 4:17 PM Daniel Rozenberg @.***> wrote:

@danielrozenberg https://github.com/danielrozenberg If youve turned off the cloudflare hosting of those domains, where is the logic for the redirects going to live?

In the DNS zone file, managed internally at Google. I made the change earlier today, but since it's non-urgent it would take a day or two to take effect

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ampproject/amp.dev/issues/5730#issuecomment-832978763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRUBWRYDW6GXHS3NL2GMDTMGRWVANCNFSM43NEPZXA .

-- patrick

danielrozenberg commented 3 years ago

Oh that's a valid point! We might get lucky and statuspage.io would do the redirect for us to match with its domain-on-record, but if not we can CNAME it to something like status-redirect.amp.dev and have the amp.dev server perform a 301

patrickkettner commented 3 years ago

okey doke - the previous setup with cloudflare would also work, if that ends up being a problem. The page rules https://support.cloudflare.com/hc/en-us/articles/200172286-Configuring-URL-forwarding-or-redirects-with-Cloudflare-Page-Rules bit I mentioned allows for this usecase. Let me know if anything needs to happen on amp.dev itself

estherkim commented 3 years ago

So we're getting a dns_probe_finished_nxdomain error now - might have to do a redirect.

danielrozenberg commented 3 years ago

So we're getting a dns_probe_finished_nxdomain error now - might have to do a redirect.

That was before the DNS finished updating; now I get an SSL error...

Alright @patrickkettner, if I change to point the CNAME to status-redirect.amp.dev can you make it redirect to the right domain?

patrickkettner commented 3 years ago

We can make it work, yeah, but I don’t believe our cert is a wildcard, so we will need to get that in place.

On Thu, May 6, 2021 at 4:17 PM Daniel Rozenberg @.***> wrote:

So we're getting a dns_probe_finished_nxdomain error now - might have to do a redirect.

That was before the DNS finished updating; now I get an SSL error...

Alright @patrickkettner https://github.com/patrickkettner, if I change to point the CNAME to status-redirect.amp.dev can you make it redirect to the right domain?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ampproject/amp.dev/issues/5730#issuecomment-833831493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRUBVQ5CDZCHL6VZGCYDTTML2OLANCNFSM43NEPZXA .

-- patrick

danielrozenberg commented 3 years ago

Quick update - I'm still working on this, I haven't forgotten. Trying to make this happen transparently at the CDN level. Hopefully will be done within a couple of days!

estherkim commented 3 years ago

yay! turned out to be more work than expected so thank you!

danielrozenberg commented 3 years ago

This is finally fixed! (in case status.ampproject.org doesn't perform the redirection for you, it's probably because the GFE rollout isn't 100% complete - it should be finished by the end of this week)