search

ampproject / amp.dev

The AMP Project Website.
https://amp.dev
Other
582 stars 694 forks source link

interactivity-dynamic-content/ComboBox.html , problem and solution #5736

Open tiuvi opened 3 years ago

tiuvi commented 3 years ago

In the amp example no data is sent

image

In this second case it makes an empty request, because an on = "... sumit" is not made

In this third photo you can see how the data is sent through the form What is missing?

image

the name attribute

image

and the submit button or an event that sends the form

Alternative

image

Event when form changes image

patrickkettner commented 3 years ago

thanks @Francisco-AM! Would you want to create pull request to fix this?

tiuvi commented 3 years ago

I already solved the problem, the correct code would be

<!doctype html> <html ⚡ lang="en">

ComboBox

image

You click on the element, the autocomplete is displayed and the form is automatically sent

image In the next photo we can see the post sent data image

I still don't have enough experience to do a pull request I'm new to github

patrickkettner commented 3 years ago

Yes - I a asking if you want to submit a pull request with the code changes.

On Mon, May 3, 2021 at 10:19 AM Francisco-AM @.***> wrote:

I already solved the problem, the correct code would be

<!doctype html>

ComboBox [image: image] You click on the element, the autocomplete is displayed and the form is automatically sent [image: image] In the next photo we can see the post sent data [image: image] — You are receiving this because you commented. Reply to this email directly, view it on GitHub , or unsubscribe .

-- patrick

tiuvi commented 3 years ago

Sure, but in my code there is no button and I think that in the example two buttons are configured, one for starting and the other for closing, which do not update the form

patrickkettner commented 3 years ago

The code is available here if you want to give it a go

tiuvi commented 3 years ago

I already made the pull request, thanks for your patience, it is my first pul request, I hope to contribute much more to amp because it is a very large project.

patrickkettner commented 3 years ago

@Francisco-AM where is the PR? I do not see it - looking forward to your contributions!

tiuvi commented 3 years ago

Now the pull is ready, before it was not sent, thankfully there were few changes