search

ampproject / ampbench

AMPBench: AMP URL validation and troubleshooting tools (DEPRECATED)
Apache License 2.0
66 stars 39 forks source link

Attribute sizes may not appear in tag 'img' #121

Open Lofesa opened 5 years ago

Lofesa commented 5 years ago

Hi In https://ampbench.appspot.com/validate?url I´m getting this message when validating a url: The attribute 'sizes' may not appear in tag 'img'. (see https://www.ampproject.org/docs/reference/components/amp-img) But in the reference page it says:

sizes

The value of the AMP sizes attribute is a sizes expression that selects the defined size corresponding to the media query based on the current window size. 
Additionally, AMP sets an inline style for width on the element. If the srcset attribute is provided, <amp-img> will autogenerate the HTML5 definition of the sizes attribute for the underlying <img>, when none is specified. If the srcset attribute is not provided, no sizes attribute will be autogenerated for the underlying <amp-img>

So sizes is a valid attribute in amp images with srcset.

Related to this, the AMP Check AMP URL fail as I can see in #113

ithinkihaveacat commented 5 years ago

Do you have a sample URL?

Lofesa commented 5 years ago

Sure: https://intersindicalrm.org/?amp

ithinkihaveacat commented 5 years ago

Thanks, have created #122 to fix this.