Unnecessary warning when using self-canonical

ampproject / ampbench

AMPBench: AMP URL validation and troubleshooting tools (DEPRECATED)

Apache License 2.0

66 stars 39 forks source link

Unnecessary warning when using self-canonical #36

Open Gregable opened 6 years ago

Gregable commented 6 years ago

https://ampbench.appspot.com/validate?url=http%3A%2F%2Fwww.ampbyexample.com%2F

[Canonical URL is reachable][WARNING: AMP link not found in the Canonical page]

I believe this warning is caused by a self-canonical AMP page, which is perfectly reasonable. The only workaround would be to add <link rel=amphtml> to an AMP HTML page, which is undesirable.

westonruter commented 6 years ago

I am seeing the same issue for https://ampbench.appspot.com/validate?url=https://xwp.co

The xwp.co site is native/canonical AMP so there is no rel=amphtml link. There is, however, a rel=canonical link. Nevertheless, I'm seeing errors for both “AMP HTML Link in Canonical page?” and “AMP HTML Link in AMP page?”.

I don't understand why xwp.co has two errors whereas ampbyexample.com only has one, but they both only have rel=canonical and no rel=amphtml.

andreban commented 6 years ago

I'm tracking the second FAIL at https://github.com/ampproject/ampbench/issues/65