AMP-to-AMP (A2A) linking

ampproject / amphtml

The AMP web component framework.

https://amp.dev

Apache License 2.0

14.88k stars 3.89k forks source link

Closed dreamofabear closed 6 years ago

dreamofabear commented 6 years ago

Features for publishers to specify navigation from an AMP page to another AMP page when served from CDN:

[x] Add per-link opt-in, e.g. <a href="example.com/amp" amp>
[x] Add whole page opt-in for all navigation features (links, AMP.navigateTo, AMP-Redirect-To) with new boolean attribute on HTML tag e.g. <html a2a-by-default>

Notes:

The viewer already has an a2a capability and page -> viewer message. See navigateTo() in viewer-impl.js
Note that this is distinct from the proposed AMP Cache transformation that adds amp-href to normal <a> URLs that it already has a cached AMP page for

/cc @lswang1618

lswang1618 commented 6 years ago

Just confirming, does per-link opt in only include anchor links or is it for all navigation features?

ithinkihaveacat commented 6 years ago

Does this have the same behavior on and off caches?

morsssss commented 6 years ago

Nice!

dreamofabear commented 6 years ago

@lswang1618 All navigation features eventually, <a> first.

@ithinkihaveacat Good question. Off cache this is a no-op.

ampprojectbot commented 6 years ago

This is a high priority issue but it hasn't been updated in awhile. @choumx Do you have any updates?

dreamofabear commented 6 years ago

dreamofabear commented 6 years ago

For links:

<a rel=amphtml href="amp.html">An AMP link</a>

For forms and actions:

<!-- Per-feature opt-in based on `content` attribute. -->
<meta name="amp-to-amp-navigation" content="AMP-Redirect-To; AMP.navigateTo">

Allowing only opt-in (no opt-out) avoids confusing situations like <a rel="amphtml noamphtml">
More configurable and future-proof with a <meta> tag instead of boolean attribute
Context for rel attribute: http://microformats.org/wiki/existing-rel-values#HTML5_link_type_extensions

/cc @cramforce

cramforce commented 6 years ago

Looks good as discussed in review. No semiconolon in content.

westonruter commented 5 years ago