search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Issue with running ads from a custom domain #1526

Closed NataliaLKB closed 8 years ago

NataliaLKB commented 8 years ago

There seems to be an issue when following these guidelines.

All iframes on the page seem to be affected. Amp-twitter for example is broken. Specifically the iframe it creates.

Here is a screenshot of how amp-twitter is being affected: image

Here is the example page: https://www.theguardian.com/books/booksblog/2016/jan/20/the-best-music-to-listen-to-while-reading-or-is-it-sacrilege/amp

cc @kenlim @stephanfowler

cramforce commented 8 years ago

This happens when opted into canary release. You can fix this on your side by amending the

if (!(/^\d+$/.test(v))) return;

in remote.html to be

if (!(/^\d+(-canary)?$/.test(v))) return;

We will update the documentation.

cramforce commented 8 years ago

@NataliaLKB Could you confirm that this fixed things for you?

NataliaLKB commented 8 years ago

Will be able to confirm momentarily

NataliaLKB commented 8 years ago

Unfortunately it doesn't seem to have solved the problem, any other ideas?

cramforce commented 8 years ago

Looking at https://www.theguardian.com/books/booksblog/2016/jan/20/the-best-music-to-listen-to-while-reading-or-is-it-sacrilege/amp I now see one add loading, but there seems to be a JS error in your own Krux related code. Could that be the problem?

NataliaLKB commented 8 years ago

I will check with that team, as it does seem to be an error there. Thanks @cramforce . Will close this issue.