search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Intent to Implement: amp-bitmovin-player #17255

Closed unki2aut closed 5 years ago

unki2aut commented 6 years ago

What's the issue?

We would like to create a amp-bitmovin-player component for our customers to use in their AMP websites.

The idea is that the component loads the Bitmovin Player from the CDN, sets it up and plays back the customers video source. We support DASH, HLS, Smooth and progressive files with all kinds of DRM providers, ads and external subtitles.

I had a look at other video components and the amp-video-ima in terms of configuration is similar flexible to what we are looking for.

Questions

1) We don't have our own content so setting a media ID would not work in this case. What would be the best way to pass the config (can be quite complex and contain callback functions) from the component definition to the player?

2) What is the best way to allow custom JavaScript to be added to our component by the customer? We would need this to allow the customer to call functions of the player.

3) I have seen the video-interface. Who does interact with the player component and calls these methods?

aghassemi commented 6 years ago

Thanks @unki2aut, to @alanorozco fo comments.

unki2aut commented 6 years ago

@alanorozco would be great to get some feedback on the possibilities to configure a custom component.

csalazart commented 6 years ago

Hello, i have some request, in some cases, we are using a video-player javascript for desktop and mobile and we using a personalize imagen for publish the article, in some cases, and other we take the image from the player, brightcove, youtuve, vimeo, etc. but in amp its not posible put a personalize image, so our article on mobile the preview image is not the same like amp article because the imagen its diferent.. if posible set a data tag atribute to put a personalize imagen en that player-video tags!? Thanks!!!

alanorozco commented 6 years ago

@unki2aut

  1. We can't really allow custom JS to run on the host document. Would an iframe'd approach work for your case?

  2. Same answer.

  3. The video-interface is used by common video features in AMP. These include autoplay, rotate-to-fullscreen, analytics, and others.

alanorozco commented 6 years ago

@csalazart Hi, I'm not sure I follow your question. Is the poster attribute enough for your use case? Please open a different issue or find help on StackOverflow.

csalazart commented 6 years ago

@alanorozco ok I understand the problem, the situation is that we do not use amp-video we use the native ones like amp-brigthcove, amp-youtube and amp-vimeo and these do not have poster attribute, so we can not customize the image of the video that we place, if we use amp-video could we use a youtube or vimeo or brigthcove url ???

csalazart commented 6 years ago

can be added the amp-img inside the amp-vimeo, amp-youtube and amp-brigthcove??? so that resolve my problem... can be?

ampprojectbot commented 5 years ago

This issue seems to be in Pending Triage for awhile. @alanorozco Please triage this to an appropriate milestone.

alanorozco commented 5 years ago

@csalazart Please ask your question on StackOverflow or on the #using-amp channel in our Slack.

mrjoro commented 5 years ago

Is this I2I still active?

dweinber commented 5 years ago

Yes, the intent is still given @mrjoro.

aghassemi commented 5 years ago

Closing this as stale for now, please reopen when ready to start crafting the implementation.

Thanks!