search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Explore integrating E2E tests with visual-diff tests #20466

Open estherkim opened 5 years ago

estherkim commented 5 years ago

Enable easier debugging when taking screenshots and doing visual-diffs. Explore merging the two test types

ampprojectbot commented 5 years ago

This issue doesn't have a category which makes it harder for us to keep track of it. Please add an appropriate category.

rsimha commented 5 years ago

Here's the section in the Percy docs on E2E testing: https://docs.percy.io/docs/end-to-end-testing

It could be valuable to integrate snapshots into our E2E tests. Maybe we can try this with one or two tests to see how they fare over multiple builds?

/cc @danielrozenberg for help with Percy accounts, etc.

rsimha commented 3 years ago

[Infra triage] I think this is still a P3, but putting this on the radar or @rileyajones for visibility.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.