In some cases, causes amp-list to not render. Specifically, amp-list that are mutated via [src] binding with local data (not URLs) where the amp-list element has a zero size (width or height == 0).
Mini-postmortem
Summary
22227 deferred rendering of amp-list [src] mutations with local data until layout. This caused amp-list elements that wouldn't be laid out normally (e.g. zero size) to never render.
Users affected
Impact
Pages that use amp-list[src] mutations with local data that have a zero size.
Upon interaction via AMP.setState, the amp-list may not appear due to its size being zero.
Root Causes
We didn't think that pages would rely on this behavior. In reality, this even affected a page on amp.dev -- AMP boilerplate generator.
Action Items
Action Item
Type
Owner
PR #
Add regression test
Prevent
@choumx
#22559
Lessons Learned
Things that went well
This was reported externally and investigated shortly during RC/canary period.
The affected duration was modest (less than 1d).
Things that went wrong
This should've been patched before it hit production, but we thought it only affected specific partners with a separate, controlled rollout.
dvoytenko
commented
5 years ago
Cherry-pick request
Why does this issue meet the cherry-pick criteria?
In some cases, causes amp-list to not render. Specifically, amp-list that are mutated via
[src]binding with local data (not URLs) where the amp-list element has a zero size (width or height == 0).Mini-postmortem
Summary
22227 deferred rendering of amp-list
[src]mutations with local data until layout. This caused amp-list elements that wouldn't be laid out normally (e.g. zero size) to never render.amp-list[src]mutations with local data that have a zero size.AMP.setState, the amp-list may not appear due to its size being zero.Root Causes
Action Items
Lessons Learned
Things that went well
Things that went wrong
/cc @ampproject/wg-approvers @ampproject/cherry-pick-approvers