search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

AMP4Email: Invalidate amp-lightbox and amp-image-lightbox #23170

Open johnbarr opened 5 years ago

johnbarr commented 5 years ago

amp-lightbox and amp-image-lightbox don't make much sense because they occupy the full height of the document (email) and don't change their appearance based on the vertical size of the outer page nor the scroll position of the outer page.

https://github.com/ampproject/amphtml/issues/22297 is one example of this.

We have come up with no good solutions to this problem and so Gmail thinks we should disable these two components because there's no good way to use them at the moment.

bburbach commented 5 years ago

I know the original Pinterest demo AMP email shown below used amp-lightbox to show more detail on clicked items. And we were evaluating some use cases that do something similar. https://www.youtube.com/watch?v=Ghx9uxvusrE

fabienbrouillaud commented 5 years ago

lightboxes are useful to easily display additional information without asking the user to leave the email (product details for exemple). They are also useful to display forms (user profile for exemple)

alexandr-kazakov commented 5 years ago

Today I saw a warning on the https://amp.gmail.dev/playground/ chrome_2019-08-01_17-34-42 http://bit.ly/2SVPZoK

Maybe you will save amp-image-lightbox after all? Such functionality would be useful to me.

Nerone95 commented 5 years ago

It's the same for amp-sidebar?

modernwarfareuplink commented 4 years ago

Are you planning on deprecating this anytime soon. We are using amp-lightbox component in production, if there is any definite timeline for deprecating this . cc @choumx

modernwarfareuplink commented 4 years ago

Another fine example other than Pinterest demo AMP email is one we have in production. can you please have a look at how useful the lightbox can be.

dreamofabear commented 4 years ago

We're reconsidering this decision. Pending a design for better UX for handling lightboxes in a threaded email conversation view.

neonithinar commented 3 years ago

Hi, we are currently developing an instant messaging service using amp-lightbox. can you suggest an alternative to amp-lightbox in this use case? PS I am just a beginner any tips and suggestions are heartily appreciated

zhangsu commented 1 year ago

There's currently no alternative.