search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Add "rollback" RTV to experiments.html for bisecting regressions #26762

Open rcebulko opened 4 years ago

rcebulko commented 4 years ago

Often when something breaks, the first step is opting into the previous Stable RTV to see if the error can be reproduced. It could be useful to have an explicit "Previous Stable Channel" next to the Experimental/Beta opt-in channels so the release on-duty and others can quickly verify if a release or cherry-pick introduced the breakage, or if it was a long-standing issue.

/cc @ampproject/wg-infra

estherkim commented 4 years ago

Not a bad idea, but the GitHub release body already has a baseline RTV. Shouldn't that be sufficient?

rcebulko commented 4 years ago

It is for us since we know where all the release info lives, but for publishers or developers who are less familiar (or even just members of the AMP team that are closer to the UI than the release Infra), it could be a lot simpler, no draft/prereleases to sort through, etc. I would still be implemented by just setting the RTV opt-in field, but I think having a preset could be helpful.

estherkim commented 4 years ago

Getting to the release page is intuitive IMO. You go to the amphtml README and click on the release badge. That's where I'd look first for any repo, whether I'm an active contributor on it or not.

On Wed, Feb 12, 2020 at 12:03 PM Ryan Cebulko notifications@github.com wrote:

It is for us since we know where all the release info lives, but for publishers or developers who are less familiar (or even just members of the AMP team that are closer to the UI than the release Infra), it could be a lot simpler, no draft/prereleases to sort through, etc

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/ampproject/amphtml/issues/26762?email_source=notifications&email_token=AKUPJUD74U2LSTFPEBCENEDRCQTX5A5CNFSM4KT5MV4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRRYVY#issuecomment-585309271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKUPJUEE7QJ6ZHPLHW37KRDRCQTX5ANCNFSM4KT5MV4A .

rsimha commented 3 years ago

[Infra triage] It has been a year since this was filed. Given that https://cdn.ampproject.org/experiments.html has this dialog available, I'm not sure it's worth the engineering effort to add new opt-in button(s).

image

However, it may be easy / useful to hyperlink the "previously released RTV" text in this dialog and make it point to a place where the user can find a list of recent releases. Assigning to @estherkim for comment on if / when this is worth doing.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.