search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.88k forks source link

Change window.context API to avoid problematic terms #30789

Open calebcordry opened 3 years ago

calebcordry commented 3 years ago

We will still need to maintain backwards compatibility, so will likely alias to the new name.

to/ @ampproject/wg-monetization

jeffkaufman commented 3 years ago

I'd suggest adding window.coordinator as an alias for window.master

jeffkaufman commented 3 years ago

and computeInCoordinatingFrame for computeInMasterFrame

Jns234 commented 2 years ago

Hello, I took up to change computeInCoordinatingFrame to computeInMasterFrame. Didn't find any instances of window.master though. Could you please check my PR? https://github.com/ampproject/amphtml/pull/38107

Jns234 commented 2 years ago

Please ignore what I did, instead of creating an alias I just renamed it.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.