search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Rename core/types to core/primitives #34362

Open rcebulko opened 3 years ago

rcebulko commented 3 years ago

Right now, src/core/types contains helpers for primitive types: function, string, array, date, enum (honorary primitive), object This was probably not the best choice of directory naming, since it can cause confusion with type declarations. I'd suggest renaming it to src/core/primitives.

The actual change itself is a fairly trivial find/replace, but since it touches many files and is an overall important directory, I wanted to get some perspectives on a) is it even worthwhile and b) bikeshedding "primitives"

@ampproject/wg-performance

samouri commented 3 years ago

definitely slightly better than types. When I see types I immediately think of externs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.