search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

AMP-Video-ima add support for AdsRenderingSettings #34786

Open spormeon opened 3 years ago

spormeon commented 3 years ago

Description

can AMP-Video-ima add support for AdsRenderingSettings , so as we can limit bitrate to e.g 1000, this is so that we try to limit "heavy ad intervention' taking place, as the SDK can choose ones over this rate with the default -1 (i think) setting.

Could help alot of people who basically have no clue how many ads are being blocked by HAI due to -1 setting choosing higher bitrates etc

Alternatives Considered

can't, can't access this setting currently

Additional Context

No response

alanorozco commented 3 years ago

A few thoughts from looking at AdsRenderingSettings.

  1. We'd likely want to exclude certain properties from being configurable. uiElements in particular should be kept as-is for consistency between ad controls and content controls.

  2. I'm not sure what the best markup interface would be. We allow a single <script> tag with JSON inside, but that corresponds to ImaSdkSettings.

Mainly considering adding a data-settings attribute to the script tag, ima/ima-settings/ImaSettings by default to support the previous syntax. ads-rendering/ads-rendering-settings/AdsRenderingSettings otherwise. We likely need to parse and clear props from the latter.

<amp-ima-video>
  <script type="application/json">
    <!-- ImaSettings -->
  </script>
  <script type="application/json" data-settings="ad-rendering">
    <!-- AdsRenderingSettings -->
  </script>
</amp-ima-video>
spormeon commented 3 years ago

whichever way works would be my vote

spormeon commented 3 years ago

any more thoughts on implementing this?

spormeon commented 3 years ago

Hi, Any intention to do this?

spormeon commented 3 years ago

@alanorozco is there any chance of getting this implemented, the HAI ads are getting more and more frequent, so this will help people alleviate it

spormeon commented 2 years ago

@alanorozco Any word of this, not having the ability to set tjis is still having effect on HAI being triggered, by what are Google ads in effect

spormeon commented 2 years ago

any info on this, noone has said anything on implementation

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

spormeon commented 1 year ago

is anyone bothering to reply on this anymore?