search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Master frame selection for amp-ad 3p vendors #35099

Open madan-mayank opened 3 years ago

madan-mayank commented 3 years ago

Description

Expected Behavior

One of the frames should be selected as master frame

Actual Behavor

All the frames are selected as master frames in chrome v91

https://github.com/ampproject/amphtml/blob/main/3p/ampcontext-integration.js#L39 throws a security error even if the frame of the passed name is present in chrome v91. This causes every frame to become master frame

Reproduction Steps

  1. Navigate to any page using 3p amp-ad vendors
  2. All the iframes are master frame

Relevant Logs

Tested on Chrome Version 91.0.4472.114 and Version Version 91.0.4472.120

Browser(s) Affected

Chrome

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

alanorozco commented 3 years ago

@ampproject/wg-monetization

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.