search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Ads no signing throwing #35708

Open powerivq opened 3 years ago

powerivq commented 3 years ago

Description

ERROR: '[amp-a4a] TypeError: amp-a4a: doubleclick: httpResponse.clone is not a function'
    The test "amp-ad-network-doubleclick-impl   #multi-size amp creative - should force iframe to match size of creative" resulted in a call to console.error. (See above line.)
    ⤷ If the error is not expected, fix the code that generated the error.
    ⤷ If the error is expected (and synchronous), use the following pattern to wrap the test code that generated the error:
        'allowConsoleError(() => { <code that generated the error> });'
    ⤷ If the error is expected (and asynchronous), use the following pattern at the top of the test:
        'expectAsyncConsoleError(<string or regex>[, <number of times the error message repeats>]);'

I think it is because the mocked response object does not support clone, but I might be wrong.

Reproduction Steps

amp unit --files=extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js would trigger that.

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.