search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Lightbox controls do not appear when in a touch environment (mouseless) #36896

Open samouri opened 2 years ago

samouri commented 2 years ago

Description

The <amp-lightbox-gallery> component should create Prev/Next buttons on the left and right side of the screen. When emulating a phone (or on an actual phone), the controls never appear.

See: image

I believe the root cause is the addition of i-amphtml-screen-reader:

https://github.com/ampproject/amphtml/blob/4b32cefe4bd761d27754db5c9bac76cad6a1b199/extensions/amp-lightbox-gallery/0.1/lightbox-controls.js#L64-L72

Reproduction Steps

  1. In Chrome, enable mobile emulation
  2. Go to https://playground.amp.dev/?url=https%3A%2F%2Fpreview.amp.dev%2Fdocumentation%2Fexamples%2Fcomponents%2Famp-lightbox-gallery&format=websites
  3. Click any image and notice that the left/right arrows do not appear

@ampproject/wg-components

JuliaTrubchyk commented 2 years ago

Same issue exist on Firefox / desktop

Screen Shot 2022-01-11 at 1 04 37 PM

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

dzarmanova commented 1 year ago

The issue is still reproducible on desktop (Chrome and Firefox browser) and on mobile android device (Chrome browser)