ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

[Story] Not enough Pixel in video served from cache=google when the video is in portrait #37853

Open llccrr opened 2 years ago

llccrr commented 2 years ago

Description

Portrait is the main media used in Story, but today video served from the cache are in 405x720px.

When we watch a landscape video (16/9) on YouTube and select 720p we get a video of 720px height giving a resolution of 1280x720px (720x16/9=1280) giving a total of 921 600px.

However, as a Story is in portrait (9/16) it's currently giving a video of 720px height and so it's giving a resolution of 405x720px (720*9/16=405) giving a total of 291 600px, 3 times lower than a usual 720p.

Obviously it can be interesting to serve a lower resolution for lower bit rate, but currently videos served for the 2000 kbps bit rate are in 405x720px which gives the equivalent of a 16/9 480p quality which is very low.

The low quality of video with good connection is a subject that our clients talk about a lot.

I think that while transcoding it should check if the video is landscape or portrait and use 720px for the smaller dimension.

Landscape : 720px in height Portrait : 720px in width

PS: Maybe the label "Type: Bug" is not the good one.

Reproduction Steps

https://perifit.my.join-stories.com/unboxing-perifit-c7pO60b/

In this story you can compare the resolution of a video from the cache and a video from the source mp4 file

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

gmajoulet commented 2 years ago

Quick update: this will be a long term project, but is highly prioritized.

llccrr commented 2 years ago

Do we have some updates on it @gmajoulet ?

gmajoulet commented 2 years ago

We're making progress on the internal infra and tooling to do these, got it prioritized, but still can't commit to any launch date.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.