search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Duplicated ad calls generated by amp-ad tag #38021

Open mlapeyre3 opened 2 years ago

mlapeyre3 commented 2 years ago

Description

We noticed that the Smart Adserver extension now generates duplicated ad requests for any given ad placement.

There is a "document" request and an "XHR" request.

This critical issue impacts all our customers as the counting discrepancies between the ad network and the ad agencies are up to 50%. Some conflicts also appeared between the two ads on the same placement, which causes significant harm to the AMP version of the customer.

The issue is fixed by https://github.com/ampproject/amphtml/pull/38014 though I am not sure to understand why we had to specifically disable the usage of XHR request whereas other extensions seem not to have done that 🧐

Reproduction Steps

Any AMP pages using the amp-ad tag from smartadserver (e.g: this page) will generate 2 ad requests for 1 ad placement.

image

The tag is: <amp-ad style="min-width: 300px; min-height: 250px; border-style: solid;" width="300" height="250" type="smartadserver" data-site="317777" data-page="1232599" data-format="84313" data-target="iid=10711111"> </amp-ad>

Relevant Logs

No console errors or warnings are logged.

Browser(s) Affected

Chrome, Firefox, Safari, Edge, UC Browser

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

2203172113000

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.