ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Very Urgent : AMP Runtime error #39380

Closed askmeoffersglobal closed 1 year ago

askmeoffersglobal commented 1 year ago

Description

I am seeing issues on AMP Runtime

Powered by AMP ⚡ HTML – Version 2308042153000 https://askmeoffers.com/aliexpress-coupons/ error-reporting.js:205 Cannot access 't' before initialization wn @ error-reporting.js:205 (anonymous) @ error-reporting.js:293 amp-worker.js:101 Uncaught (in promise) ReferenceError: Cannot access 't' before initialization at new (amp-worker.js:101:9) at Y (service-helpers.js:350:13) at q (service-helpers.js:141:10) at amp-worker.js:38:18 at Object.aEt (bind-impl.js:1603:12) at Object.Te (bind-impl.js:594:17) at bind-impl.js:202:12

Reproduction Steps

Open Aliexpress Coupon code Hit the search bar to popup which is implemented in AMP check the console it shows error and nothing works

Relevant Logs

No response

Browser(s) Affected

Chrome

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

2308042153000

askmeoffersglobal commented 1 year ago

image @caroqliu kindly check this

askmeoffersglobal commented 1 year ago

@niallkennedy @ZachNusbaum @niallkennedy @ampprojectbot @mkhatib @niallkennedy @zeno

askmeoffersglobal commented 1 year ago

@caroqliu This is very HIGH PRIORITY ISSUE everything in AMP is completely broken .

askmeoffersglobal commented 1 year ago

@dickie81 Please check this

erwinmombay commented 1 year ago

looking

askmeoffersglobal commented 1 year ago

Dear @erwinmombay,

I trust this message finds you well. I wanted to provide an update on the investigation I've conducted regarding the search functionality issue that has come to our attention. I deeply appreciate your understanding and patience as we work to resolve this matter.

To ensure a comprehensive understanding of the situation, I undertook the following steps prior to reporting this issue:

Review of Site Infrastructure: Our website operates on WordPress and is integrated with the official AMP plugin. Up until recently, all components were functioning as expected.

Sudden Disruption: It was brought to our attention that the search functionality on our site has ceased to operate as intended.

Server Testing: We took proactive measures to troubleshoot the issue by deploying the website code on different servers, including platforms like WP Engine, to determine if the problem persisted across various environments.

Thematic Analysis: As part of our investigation, we tested the site using the default WordPress theme with the AMP plugin activated. Regrettably, the issue remained unresolved.

It's important to underscore the significance of this issue, as its impact spans a vast user base. Millions of sites, potentially affecting trillions of visitors, rely on AMP for optimal performance. Our continued diligence is aimed at rectifying this situation promptly to minimize any disruption across the ecosystem.

Once again, I am genuinely grateful for your cooperation and dedication in addressing this matter. Your insights and expertise are invaluable as we work towards a resolution that benefits our entire community.

Thank you for your understanding and continued support.

erwinmombay commented 1 year ago

conducting a rollback

erwinmombay commented 1 year ago

hey all. rollback completed.

I'm leaving this issue open for now to apply a fix to our canary builds and fix the actual bug

dickie81 commented 1 year ago

You will find the bug was introduced in this commit https://github.com/ampproject/amphtml/commit/54c040015323502c18d65b31a03aec69b98dd0b3 around line 101

erwinmombay commented 1 year ago

@dickie81 much appreciated!

erwinmombay commented 1 year ago

Verified that our fix works on experimental/beta. working on making sure this type of bug doesn't occur again