search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

amp-story-player: prev and next story buttons are hidden on Chrome #40119

Closed MLB-Qwang closed 3 weeks ago

MLB-Qwang commented 3 months ago

Description

Expected Prev and next story buttons are visible in amp-story-player across all browsers (not full-bleed)

Current Prev and next story buttons are hidden in Chrome

I'm looking at the CSS and it looks like Chrome is not respecting :not(.i-amphtml-story-player-panel):

Screenshot 2024-08-15 at 2 28 11 PM

Reproduction Steps

Reproducible via this URL that loads multiple stories:

https://www.mlb.com/stories

Relevant Logs

No response

Browser(s) Affected

Chrome

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

2406131415000

erwinmombay commented 2 months ago

@ychsieh do you mind taking a look at this when you get a chance

MLB-Qwang commented 1 month ago

Hey guys, any updates on this?

ychsieh commented 1 month ago

@processprocess could you take a look at the quick fix: #40124? Thanks!

ychsieh commented 3 weeks ago

The PR is merged. Closing this for now.