search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Rename Brid player to TargetVideo #40130

Closed danijel-ristic closed 1 month ago

danijel-ristic commented 2 months ago

Summary

Rename amp-brid-player to amp-target-video-player

Design Document

No response

Motivation

Brid.tv got acquired by TargetVideo so we need to rename amp-brid-player to amp-target-video-player

Alternative Solutions

Since we need to keep amp-brid-player working until we migrate all amp players to TargetVideo, I guess I need to create new TargetVideo player extension and after we migrate I need to create new PR to remove amp-brid-player, can anyone confirm if this is correct process for doing this.

Launch Tracker

No response

Notifications

/cc @ampproject/wg-approvers

danijel-ristic commented 2 months ago

cc @ampproject/wg-approvers

danijel-ristic commented 2 months ago

cc @erwinmombay @powerivq @ychsieh

powerivq commented 2 months ago

@danijel-ristic Yes, you should move the extension to the new name, and set the old one as an alias.

danijel-ristic commented 2 months ago

@powerivq How would I alias old one to the new one, I tried to find examples, docs but I wasn't lucky. Could you point me in the right direction? Thanks in advance.

powerivq commented 2 months ago

@danijel-ristic https://github.com/ampproject/amphtml/blob/main/extensions/amp-ad/0.1/amp-ad.js#L127

For example, amp-embed is an alias of amp-ad.