search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Object.assign polyfill is missing in 3p iframe #4877

Closed cramforce closed 8 years ago

cramforce commented 8 years ago

Seeing lots of errors in prod that got hidden due to logging weirdness.

lannka commented 8 years ago

But I saw openx.js is the only one using Object.assign in 3P.

lannka commented 8 years ago

Wait, I thought errors in iframe is not reporting back?

cramforce commented 8 years ago

We do during initial execution (just a single try-catch), but not window.onerror

cramforce commented 8 years ago

Yeah, seems to be openx only.

cramforce commented 8 years ago

@caleb-sotelo can you take on fixing this. Object.assign is not yet everywhere https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign

jridgewell commented 8 years ago

Submitted #4890 since @caleb-sotelo isn't a user on Github anymore.