search

ampproject / amphtml

The AMP web component framework.
https://amp.dev
Apache License 2.0
14.89k stars 3.89k forks source link

Intent to Implement: Custom variables support for OpenX amp-ads #7937

Closed rjvelicaria closed 7 years ago

rjvelicaria commented 7 years ago

We plan to implement custom variables support for OpenX amp-ads. The changes will be on https://github.com/openx/amphtml under a new branch called custom-variables.

Company Name: OpenX Technologies, Inc.

aghassemi commented 7 years ago

/to @lannka @jasti

rjvelicaria commented 7 years ago

Are new implementations de-prioritized for the moment?
Just wondering why there's no one looking into this.

erwinmombay commented 7 years ago

friendly ping for @lannka and @jasti

@rjvelicaria apologies, with the first amp conference happening last week everybody schedule has just been backed up.

rjvelicaria commented 7 years ago

I see. Thanks for the info, @erwinmombay !

jasti commented 7 years ago

@rjvelicaria Sorry about the delay. Can you please explain what you specifically mean by custom variables? What purpose do they serve? Would this only impact the open x ad extension?

rjvelicaria commented 7 years ago

@jasti This only impacts the OpenX ad extension.
I might've phrased the title wrong, but the intention is to have the OpenX ad extension support more features that the exchange provides via a normal tag. Some publishers will want to have their own "settings"/ "configurations" passed in to the exchange and this provides them a way to do it within AMP.

jasti commented 7 years ago

Great, look forward to the PR.

rjvelicaria commented 7 years ago

We can close this. This feature was successfully released at around 2017-03-31.