search

ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
418 stars 151 forks source link

[A11Y] Android: Carousel captions on components page are not displayed appropriately with regular/Large text and display size #392

Closed gkhadke closed 7 years ago

gkhadke commented 7 years ago

ENVIRONMENT:

OS (number): O Build number: marlin-userdebug O MASTER eng.cbrowe.20170410.155415 dev-keys Form factor (Smartphone / tablet): PIXEL XL Browser: Chrome Dev 59.0.3062.4

PRE-REQUISITE Font size and display size are set to “Largest” (Settings > Accessibility)

STEPS TO REPRODUCE:

  1. Open https://ampstart.com
  2. Tap on COMPONENTS link.
  3. Verify the Carousel with captions section.

ACTUAL RESULTS: Caption below respective carousel images is cutting off completely when font size and display size are set to “Largest”. Even with default font size and display size, some part of caption is cutting off.

Observation: Issue is only existing on smartphones. Verified on 6P and Pixel XL.

EXPECTED RESULTS:

Carousel image captions should be displayed appropriately for all size of font and display settings. Ensure that, actual scalable text is used for the captions. Images should not be used instead of text for the captions.

ATTACHMENT(S):

carouselwithcaptions_1 carouselwithcaptions_2 carouselwithcaptions_regularsize
camelburrito commented 7 years ago

This is a downside of amp-carousel itself not of amp start - i did increase the height of the carousel as a part of this PR - https://github.com/ampproject/ampstart/pull/457