search

ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
418 stars 151 forks source link

[Gallery - Exhibit page] #713

Closed spacedino closed 6 years ago

spacedino commented 7 years ago

Current Entire exhibit page moves horizontally even though there is only a slider at the top. It makes the rest of the page look a little off.

img_98311

Should be Can we restrict this for the rest of the page? Is this because of the carousel at the top?

camelburrito commented 6 years ago

This is still not fixed. I debugged this issue for you - 

<svg class="gallery-inner-background-2 block" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1167 599" aria-hidden="true"><path d="M8 359.5c0 143.5 56.5 179 177.5 179s150.054-30 286-30S737 594 879.5 594 1159 543.5 1159 299.5 1062.734 5 902 5C741.266 5 689 220 568 220s-333.383-72.5-425-72.5c-91.617 0-135 68.5-135 212z" fill="#f5f6fd"></path></svg>

This is what is causing the page to scroll, I guess may be setting this as a background image to the carousel (and adding a bit of padding on the carousel would help your case.)

davidtapp commented 6 years ago

@camelburrito can you let us know where you're seeing this (browser etc)? We're having trouble reproducing it and think we caught it in most browsers.

camelburrito commented 6 years ago

iPhone safari

bentranter commented 6 years ago

Sorry @camelburrito, I think I'll need a specific iOS version to repro this 😞 tried on iOS Safari 11.1.2 on iPhone 6+, and I don't observe the issue.

camelburrito commented 6 years ago

I used iphone 6s and 11.0.3