ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
418 stars 151 forks source link

[Land and See - Home] Text is too hard to read on Hero Carousel #722

Closed spacedino closed 6 years ago

spacedino commented 7 years ago

Current Text is too small and too light. image

Should be 1.25 rem size / 1.25 line height ; .85 Opactiy image

afilbert commented 7 years ago

I can increase the opacity, as I made a development decision to try and achieve a semi-bold look where the web fonts failed to cooperate consistently. The sizing, however, closely follows the approved mocks.

spacedino commented 6 years ago

Design mocks @1024px width - image

Actual @1024px width -

image

The sizing is close but does look a little bigger in the mock ups proportionally. I totally get that you want to follow what was intended. I think I actually misread the mockups and was scaling them up in my browser because I thought they were scaled down. I didn't realize the whole time that was for 1024px wide, I should have clarified. In any event, ideally you could make the changes if its easy and quick (the line height is definitely larger in the mock up) and if not we can just adjust it on our end. So feel free to disregard if you don't have the bandwith. Thanks!!

cc @mattludwig @ericlindley-g @camelburrito

spacedino commented 6 years ago

lets see if we can change this in variables.

camelburrito commented 6 years ago

No this has to be individually changed